|
Takashi Iwai |
4346aa |
From 91356fed6afd1c83bf0d3df1fc336d54e38f0458 Mon Sep 17 00:00:00 2001
|
|
Takashi Iwai |
4346aa |
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
|
|
Takashi Iwai |
4346aa |
Date: Tue, 23 Mar 2021 17:36:20 +0200
|
|
Takashi Iwai |
4346aa |
Subject: [PATCH] usb: gadget: pch_udc: Replace cpu_to_le32() by lower_32_bits()
|
|
Takashi Iwai |
4346aa |
Git-commit: 91356fed6afd1c83bf0d3df1fc336d54e38f0458
|
|
Takashi Iwai |
4346aa |
Patch-mainline: v5.13-rc1
|
|
Takashi Iwai |
4346aa |
References: git-fixes
|
|
Takashi Iwai |
4346aa |
|
|
Takashi Iwai |
4346aa |
Either way ~0 will be in the correct byte order, hence
|
|
Takashi Iwai |
4346aa |
replace cpu_to_le32() by lower_32_bits(). Moreover,
|
|
Takashi Iwai |
4346aa |
it makes sparse happy, otherwise it complains:
|
|
Takashi Iwai |
4346aa |
|
|
Takashi Iwai |
4346aa |
.../pch_udc.c:1813:27: warning: incorrect type in assignment (different base types)
|
|
Takashi Iwai |
4346aa |
.../pch_udc.c:1813:27: expected unsigned int [usertype] dataptr
|
|
Takashi Iwai |
4346aa |
.../pch_udc.c:1813:27: got restricted __le32 [usertype]
|
|
Takashi Iwai |
4346aa |
|
|
Takashi Iwai |
4346aa |
Fixes: f646cf94520e ("USB device driver of Topcliff PCH")
|
|
Takashi Iwai |
4346aa |
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
|
|
Takashi Iwai |
4346aa |
Link: https://lore.kernel.org/r/20210323153626.54908-1-andriy.shevchenko@linux.intel.com
|
|
Takashi Iwai |
4346aa |
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
|
Takashi Iwai |
4346aa |
Acked-by: Takashi Iwai <tiwai@suse.de>
|
|
Takashi Iwai |
4346aa |
|
|
Takashi Iwai |
4346aa |
---
|
|
Takashi Iwai |
4346aa |
drivers/usb/gadget/udc/pch_udc.c | 2 +-
|
|
Takashi Iwai |
4346aa |
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
Takashi Iwai |
4346aa |
|
|
Takashi Iwai |
4346aa |
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c
|
|
Takashi Iwai |
4346aa |
index a3c1fc924268..c517186384bc 100644
|
|
Takashi Iwai |
4346aa |
--- a/drivers/usb/gadget/udc/pch_udc.c
|
|
Takashi Iwai |
4346aa |
+++ b/drivers/usb/gadget/udc/pch_udc.c
|
|
Takashi Iwai |
4346aa |
@@ -1756,7 +1756,7 @@ static struct usb_request *pch_udc_alloc_request(struct usb_ep *usbep,
|
|
Takashi Iwai |
4346aa |
}
|
|
Takashi Iwai |
4346aa |
/* prevent from using desc. - set HOST BUSY */
|
|
Takashi Iwai |
4346aa |
dma_desc->status |= PCH_UDC_BS_HST_BSY;
|
|
Takashi Iwai |
4346aa |
- dma_desc->dataptr = cpu_to_le32(DMA_ADDR_INVALID);
|
|
Takashi Iwai |
4346aa |
+ dma_desc->dataptr = lower_32_bits(DMA_ADDR_INVALID);
|
|
Takashi Iwai |
4346aa |
req->td_data = dma_desc;
|
|
Takashi Iwai |
4346aa |
req->td_data_last = dma_desc;
|
|
Takashi Iwai |
4346aa |
req->chain_len = 1;
|
|
Takashi Iwai |
4346aa |
--
|
|
Takashi Iwai |
4346aa |
2.26.2
|
|
Takashi Iwai |
4346aa |
|