Takashi Iwai 29c196
From 601a5bc1aeef772ab1f47582fd322957799f5ab5 Mon Sep 17 00:00:00 2001
Takashi Iwai 29c196
From: Pavel Hofman <pavel.hofman@ivitera.com>
Takashi Iwai 29c196
Date: Wed, 5 Jan 2022 11:46:43 +0100
Takashi Iwai 29c196
Subject: [PATCH] usb: gadget: u_audio: Subdevice 0 for capture ctls
Takashi Iwai 29c196
Git-commit: 601a5bc1aeef772ab1f47582fd322957799f5ab5
Takashi Iwai 29c196
Patch-mainline: v5.17-rc1
Takashi Iwai 29c196
References: git-fixes
Takashi Iwai 29c196
Takashi Iwai 29c196
Both capture and playback alsa devices use subdevice 0. Yet capture-side
Takashi Iwai 29c196
ctls are defined for subdevice 1. The patch sets subdevice 0 for them.
Takashi Iwai 29c196
Takashi Iwai 29c196
Fixes: 02de698ca812 ("usb: gadget: u_audio: add bi-directional volume and mute support")
Takashi Iwai 29c196
Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
Takashi Iwai 29c196
Link: https://lore.kernel.org/r/20220105104643.90125-1-pavel.hofman@ivitera.com
Takashi Iwai 29c196
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Takashi Iwai 29c196
Acked-by: Takashi Iwai <tiwai@suse.de>
Takashi Iwai 29c196
Takashi Iwai 29c196
---
Takashi Iwai 29c196
 drivers/usb/gadget/function/u_audio.c | 4 ++--
Takashi Iwai 29c196
 1 file changed, 2 insertions(+), 2 deletions(-)
Takashi Iwai 29c196
Takashi Iwai 29c196
diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c
Takashi Iwai 29c196
index 4fb05f9576a6..4561d7a183ff 100644
Takashi Iwai 29c196
--- a/drivers/usb/gadget/function/u_audio.c
Takashi Iwai 29c196
+++ b/drivers/usb/gadget/function/u_audio.c
Takashi Iwai 29c196
@@ -1147,7 +1147,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name,
Takashi Iwai 29c196
 			}
Takashi Iwai 29c196
 
Takashi Iwai 29c196
 			kctl->id.device = pcm->device;
Takashi Iwai 29c196
-			kctl->id.subdevice = i;
Takashi Iwai 29c196
+			kctl->id.subdevice = 0;
Takashi Iwai 29c196
 
Takashi Iwai 29c196
 			err = snd_ctl_add(card, kctl);
Takashi Iwai 29c196
 			if (err < 0)
Takashi Iwai 29c196
@@ -1170,7 +1170,7 @@ int g_audio_setup(struct g_audio *g_audio, const char *pcm_name,
Takashi Iwai 29c196
 			}
Takashi Iwai 29c196
 
Takashi Iwai 29c196
 			kctl->id.device = pcm->device;
Takashi Iwai 29c196
-			kctl->id.subdevice = i;
Takashi Iwai 29c196
+			kctl->id.subdevice = 0;
Takashi Iwai 29c196
 
Takashi Iwai 29c196
 
Takashi Iwai 29c196
 			kctl->tlv.c = u_audio_volume_tlv;
Takashi Iwai 29c196
-- 
Takashi Iwai 29c196
2.31.1
Takashi Iwai 29c196