From 9d6d5303c39b8bc182475b22f45504106a07f086 Mon Sep 17 00:00:00 2001

From: Liang He <windhl@126.com>

Date: Sat, 18 Jun 2022 10:32:05 +0800

Subject: [PATCH] usb: renesas: Fix refcount leak bug

Git-commit: 9d6d5303c39b8bc182475b22f45504106a07f086

Patch-mainline: v6.0-rc1

References: git-fixes

In usbhs_rza1_hardware_init(), of_find_node_by_name() will return

a node pointer with refcount incremented. We should use of_node_put()

when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>

Link: https://lore.kernel.org/r/20220618023205.4056548-1-windhl@126.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Takashi Iwai <tiwai@suse.de>

---

 drivers/usb/renesas_usbhs/rza.c | 4 ++++

 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/renesas_usbhs/rza.c b/drivers/usb/renesas_usbhs/rza.c

index 24de64edb674..2d77edefb4b3 100644

--- a/drivers/usb/renesas_usbhs/rza.c

+++ b/drivers/usb/renesas_usbhs/rza.c

@@ -23,6 +23,10 @@ static int usbhs_rza1_hardware_init(struct platform_device *pdev)

 	extal_clk = of_find_node_by_name(NULL, "extal");

 	of_property_read_u32(usb_x1_clk, "clock-frequency", &freq_usb);

 	of_property_read_u32(extal_clk, "clock-frequency", &freq_extal);

+

+	of_node_put(usb_x1_clk);

+	of_node_put(extal_clk);

+

 	if (freq_usb == 0) {

 		if (freq_extal == 12000000) {

 			/* Select 12MHz XTAL */

-- 

2.35.3