Juergen Gross 00244a
Patch-mainline: v6.0-rc1
Juergen Gross 00244a
Git-commit: 6e345f8c7cd029ad3aaece15ad4425ac26e4eb63
Juergen Gross 00244a
References: git-fixes
Juergen Gross 00244a
From: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Juergen Gross 00244a
Date: Mon, 1 Aug 2022 14:38:59 +0800
Juergen Gross 00244a
Subject: [PATCH] virtio_net: split free_unused_bufs()
Juergen Gross 00244a
Juergen Gross 00244a
This patch separates two functions for freeing sq buf and rq buf from
Juergen Gross 00244a
free_unused_bufs().
Juergen Gross 00244a
Juergen Gross 00244a
When supporting the enable/disable tx/rq queue in the future, it is
Juergen Gross 00244a
necessary to support separate recovery of a sq buf or a rq buf.
Juergen Gross 00244a
Juergen Gross 00244a
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Juergen Gross 00244a
Acked-by: Jason Wang <jasowang@redhat.com>
Juergen Gross 00244a
Message-Id: <20220801063902.129329-40-xuanzhuo@linux.alibaba.com>
Juergen Gross 00244a
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Juergen Gross 00244a
Signed-off-by: Juergen Gross <jgross@suse.com>
Juergen Gross 00244a
---
Juergen Gross 00244a
 drivers/net/virtio_net.c | 41 ++++++++++++++++++++++++----------------
Juergen Gross 00244a
 1 file changed, 25 insertions(+), 16 deletions(-)
Juergen Gross 00244a
Juergen Gross 00244a
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
Juergen Gross 00244a
index 204bfe49d6b4..8cad913926e5 100644
Juergen Gross 00244a
--- a/drivers/net/virtio_net.c
Juergen Gross 00244a
+++ b/drivers/net/virtio_net.c
Juergen Gross 00244a
@@ -3168,6 +3168,27 @@ static void free_receive_page_frags(struct virtnet_info *vi)
Juergen Gross 00244a
 			put_page(vi->rq[i].alloc_frag.page);
Juergen Gross 00244a
 }
Juergen Gross 00244a
 
Juergen Gross 00244a
+static void virtnet_sq_free_unused_buf(struct virtqueue *vq, void *buf)
Juergen Gross 00244a
+{
Juergen Gross 00244a
+	if (!is_xdp_frame(buf))
Juergen Gross 00244a
+		dev_kfree_skb(buf);
Juergen Gross 00244a
+	else
Juergen Gross 00244a
+		xdp_return_frame(ptr_to_xdp(buf));
Juergen Gross 00244a
+}
Juergen Gross 00244a
+
Juergen Gross 00244a
+static void virtnet_rq_free_unused_buf(struct virtqueue *vq, void *buf)
Juergen Gross 00244a
+{
Juergen Gross 00244a
+	struct virtnet_info *vi = vq->vdev->priv;
Juergen Gross 00244a
+	int i = vq2rxq(vq);
Juergen Gross 00244a
+
Juergen Gross 00244a
+	if (vi->mergeable_rx_bufs)
Juergen Gross 00244a
+		put_page(virt_to_head_page(buf));
Juergen Gross 00244a
+	else if (vi->big_packets)
Juergen Gross 00244a
+		give_pages(&vi->rq[i], buf);
Juergen Gross 00244a
+	else
Juergen Gross 00244a
+		put_page(virt_to_head_page(buf));
Juergen Gross 00244a
+}
Juergen Gross 00244a
+
Juergen Gross 00244a
 static void free_unused_bufs(struct virtnet_info *vi)
Juergen Gross 00244a
 {
Juergen Gross 00244a
 	void *buf;
Juergen Gross 00244a
@@ -3175,26 +3196,14 @@ static void free_unused_bufs(struct virtnet_info *vi)
Juergen Gross 00244a
 
Juergen Gross 00244a
 	for (i = 0; i < vi->max_queue_pairs; i++) {
Juergen Gross 00244a
 		struct virtqueue *vq = vi->sq[i].vq;
Juergen Gross 00244a
-		while ((buf = virtqueue_detach_unused_buf(vq)) != NULL) {
Juergen Gross 00244a
-			if (!is_xdp_frame(buf))
Juergen Gross 00244a
-				dev_kfree_skb(buf);
Juergen Gross 00244a
-			else
Juergen Gross 00244a
-				xdp_return_frame(ptr_to_xdp(buf));
Juergen Gross 00244a
-		}
Juergen Gross 00244a
+		while ((buf = virtqueue_detach_unused_buf(vq)) != NULL)
Juergen Gross 00244a
+			virtnet_sq_free_unused_buf(vq, buf);
Juergen Gross 00244a
 	}
Juergen Gross 00244a
 
Juergen Gross 00244a
 	for (i = 0; i < vi->max_queue_pairs; i++) {
Juergen Gross 00244a
 		struct virtqueue *vq = vi->rq[i].vq;
Juergen Gross 00244a
-
Juergen Gross 00244a
-		while ((buf = virtqueue_detach_unused_buf(vq)) != NULL) {
Juergen Gross 00244a
-			if (vi->mergeable_rx_bufs) {
Juergen Gross 00244a
-				put_page(virt_to_head_page(buf));
Juergen Gross 00244a
-			} else if (vi->big_packets) {
Juergen Gross 00244a
-				give_pages(&vi->rq[i], buf);
Juergen Gross 00244a
-			} else {
Juergen Gross 00244a
-				put_page(virt_to_head_page(buf));
Juergen Gross 00244a
-			}
Juergen Gross 00244a
-		}
Juergen Gross 00244a
+		while ((buf = virtqueue_detach_unused_buf(vq)) != NULL)
Juergen Gross 00244a
+			virtnet_rq_free_unused_buf(vq, buf);
Juergen Gross 00244a
 	}
Juergen Gross 00244a
 }
Juergen Gross 00244a
 
Juergen Gross 00244a
-- 
Juergen Gross 00244a
2.35.3
Juergen Gross 00244a