Juergen Gross da7bbc
Patch-mainline: v6.4-rc1
Juergen Gross da7bbc
Git-commit: f8bb5104394560e29017c25bcade4c6b7aabd108
Juergen Gross da7bbc
References: git-fixes
Juergen Gross da7bbc
From: Wenliang Wang <wangwenliang.1995@bytedance.com>
Juergen Gross da7bbc
Date: Thu, 4 May 2023 10:27:06 +0800
Juergen Gross da7bbc
Subject: [PATCH] virtio_net: suppress cpu stall when free_unused_bufs
Juergen Gross da7bbc
Juergen Gross da7bbc
For multi-queue and large ring-size use case, the following error
Juergen Gross da7bbc
occurred when free_unused_bufs:
Juergen Gross da7bbc
rcu: INFO: rcu_sched self-detected stall on CPU.
Juergen Gross da7bbc
Juergen Gross da7bbc
Fixes: 986a4f4d452d ("virtio_net: multiqueue support")
Juergen Gross da7bbc
Signed-off-by: Wenliang Wang <wangwenliang.1995@bytedance.com>
Juergen Gross da7bbc
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Juergen Gross da7bbc
Signed-off-by: David S. Miller <davem@davemloft.net>
Juergen Gross da7bbc
Signed-off-by: Juergen Gross <jgross@suse.com>
Juergen Gross da7bbc
---
Juergen Gross da7bbc
 drivers/net/virtio_net.c | 2 ++
Juergen Gross da7bbc
 1 file changed, 2 insertions(+)
Juergen Gross da7bbc
Juergen Gross da7bbc
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
Juergen Gross da7bbc
index 8d8038538fc4..a12ae26db0e2 100644
Juergen Gross da7bbc
--- a/drivers/net/virtio_net.c
Juergen Gross da7bbc
+++ b/drivers/net/virtio_net.c
Juergen Gross da7bbc
@@ -3560,12 +3560,14 @@ static void free_unused_bufs(struct virtnet_info *vi)
Juergen Gross da7bbc
 		struct virtqueue *vq = vi->sq[i].vq;
Juergen Gross da7bbc
 		while ((buf = virtqueue_detach_unused_buf(vq)) != NULL)
Juergen Gross da7bbc
 			virtnet_sq_free_unused_buf(vq, buf);
Juergen Gross da7bbc
+		cond_resched();
Juergen Gross da7bbc
 	}
Juergen Gross da7bbc
 
Juergen Gross da7bbc
 	for (i = 0; i < vi->max_queue_pairs; i++) {
Juergen Gross da7bbc
 		struct virtqueue *vq = vi->rq[i].vq;
Juergen Gross da7bbc
 		while ((buf = virtqueue_detach_unused_buf(vq)) != NULL)
Juergen Gross da7bbc
 			virtnet_rq_free_unused_buf(vq, buf);
Juergen Gross da7bbc
+		cond_resched();
Juergen Gross da7bbc
 	}
Juergen Gross da7bbc
 }
Juergen Gross da7bbc
 
Juergen Gross da7bbc
-- 
Juergen Gross da7bbc
2.35.3
Juergen Gross da7bbc