From 17d45d2425238980bdd2c6115b6881488f06f0ee Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: May 08 2023 09:12:55 +0000 Subject: platform/x86: alienware-wmi: Adjust instance of wmi_evaluate_method calls to 0 (git-fixes). --- diff --git a/patches.suse/platform-x86-alienware-wmi-Adjust-instance-of-wmi_ev.patch b/patches.suse/platform-x86-alienware-wmi-Adjust-instance-of-wmi_ev.patch new file mode 100644 index 0000000..6669fb5 --- /dev/null +++ b/patches.suse/platform-x86-alienware-wmi-Adjust-instance-of-wmi_ev.patch @@ -0,0 +1,59 @@ +From c0e4aa78716401e8d7d5434b69bbf6596b55a936 Mon Sep 17 00:00:00 2001 +From: Mario Limonciello +Date: Wed, 21 Jun 2017 17:01:35 -0500 +Subject: [PATCH] platform/x86: alienware-wmi: Adjust instance of + wmi_evaluate_method calls to 0 +Git-commit: c0e4aa78716401e8d7d5434b69bbf6596b55a936 +References: git-fixes +Patch-mainline: v4.13-rc1 + +Pali recently noticed that WMI instances are zero indexed. + +The only reason that these calls all worked properly is because the ASL +didn't verify the instance number. + +Signed-off-by: Mario Limonciello +Signed-off-by: Darren Hart (VMware) +Signed-off-by: Oliver Neukum +--- + drivers/platform/x86/alienware-wmi.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c +index d6b34923fb4e..9866fec78c1c 100644 +--- a/drivers/platform/x86/alienware-wmi.c ++++ b/drivers/platform/x86/alienware-wmi.c +@@ -303,7 +303,7 @@ static int alienware_update_led(struct platform_zone *zone) + } + pr_debug("alienware-wmi: guid %s method %d\n", guid, method_id); + +- status = wmi_evaluate_method(guid, 1, method_id, &input, NULL); ++ status = wmi_evaluate_method(guid, 0, method_id, &input, NULL); + if (ACPI_FAILURE(status)) + pr_err("alienware-wmi: zone set failure: %u\n", status); + return ACPI_FAILURE(status); +@@ -352,7 +352,7 @@ static int wmax_brightness(int brightness) + }; + input.length = (acpi_size) sizeof(args); + input.pointer = &args; +- status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1, ++ status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0, + WMAX_METHOD_BRIGHTNESS, &input, NULL); + if (ACPI_FAILURE(status)) + pr_err("alienware-wmi: brightness set failure: %u\n", status); +@@ -506,10 +506,10 @@ static acpi_status alienware_wmax_command(struct wmax_basic_args *in_args, + if (out_data != NULL) { + output.length = ACPI_ALLOCATE_BUFFER; + output.pointer = NULL; +- status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1, ++ status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0, + command, &input, &output); + } else +- status = wmi_evaluate_method(WMAX_CONTROL_GUID, 1, ++ status = wmi_evaluate_method(WMAX_CONTROL_GUID, 0, + command, &input, NULL); + + if (ACPI_SUCCESS(status) && out_data != NULL) { +-- +2.40.1 + diff --git a/series.conf b/series.conf index 0de68a4..764a71f 100644 --- a/series.conf +++ b/series.conf @@ -3540,6 +3540,7 @@ patches.suse/platform-x86-ideapad-laptop-Add-Y520-15IKBN-to-no_hw patches.suse/platform-x86-ideapad-laptop-Add-Y720-15IKBN-to-no_hw patches.suse/platform-x86-dell-laptop-Fix-bogus-keyboard-backligh.patch + patches.suse/platform-x86-alienware-wmi-Adjust-instance-of-wmi_ev.patch patches.suse/platform-x86-dell-wmi-led-Adjust-instance-of-wmi_eva.patch patches.suse/KVM-Tidy-the-whitespace-in-nested_svm_check_permissi.patch patches.suse/KVM-white-space-cleanup-in-nested_vmx_setup_ctls_msr.patch