From 4ab09d0ec3c81aceaebf8967efe111ba69a406d8 Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Mon, 30 Oct 2017 17:29:27 +0000 Subject: [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Mime-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit Git-commit: 4ab09d0ec3c81aceaebf8967efe111ba69a406d8 Patch-mainline: v4.16-rc1 References: FATE#322643 bsc#1055900 To quote kbuild/makefiles.txt: cc-disable-warning checks if gcc supports a given warning and returns the commandline switch to disable it. This special function is needed, because gcc 4.4 and later accept any unknown -Wno-* option and only warn about it if there is another warning in the source file. This is exactly what we were trying to achieve with cc-option -Wno-foo and failed miserably. Reported-by: kbuild-all@01.org Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full") Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20171030172927.18158-1-chris@chris-wilson.co.uk Reviewed-by: Ville Syrjälä Acked-by: Takashi Iwai --- drivers/gpu/drm/i915/Makefile | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/drivers/gpu/drm/i915/Makefile +++ b/drivers/gpu/drm/i915/Makefile @@ -12,15 +12,15 @@ # will most likely get a sudden build breakage... Hopefully we will fix # new warnings before CI updates! subdir-ccflags-y := -Wall -Wextra -subdir-ccflags-y += $(call cc-option,-Wno-unused-parameter,) -subdir-ccflags-y += $(call cc-option,-Wno-type-limits,) -subdir-ccflags-y += $(call cc-option,-Wno-missing-field-initializers,) -subdir-ccflags-y += $(call cc-option,-Wno-implicit-fallthrough,) +subdir-ccflags-y += $(call cc-disable-warning, unused-parameter) +subdir-ccflags-y += $(call cc-disable-warning, type-limits) +subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers) +subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough) subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror # Fine grained warnings disable -CFLAGS_i915_pci.o = $(call cc-option,-Wno-override-init,) -CFLAGS_intel_fbdev.o = $(call cc-option,-Wno-override-init,) +CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init) +CFLAGS_intel_fbdev.o = $(call cc-disable-warning, override-init) subdir-ccflags-y += \ $(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)