From: Alex Deucher Date: Tue, 13 Mar 2018 20:43:00 -0500 Subject: drm/amdgpu/powerplay/vega10: fix memory leak in error path Git-commit: a423f79ad74710bf4d0c16bf0435ad84830dd35c Patch-mainline: v4.17-rc1 References: FATE#326289 FATE#326079 FATE#326049 FATE#322398 FATE#326166 Free the backend structure if we fail to allocate device memory. Reviewed-by: Evan Quan Reviewed-by: Rex Zhu Signed-off-by: Alex Deucher Acked-by: Petr Tesarik --- drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c @@ -406,9 +406,8 @@ static int vega10_smu_init(struct pp_hwm &handle, &mc_addr, &kaddr); - if (ret) - return -EINVAL; + goto free_backend; priv->smu_tables.entry[PPTABLE].version = 0x01; priv->smu_tables.entry[PPTABLE].size = sizeof(PPTable_t); @@ -511,6 +510,9 @@ err0: amdgpu_bo_free_kernel(&priv->smu_tables.entry[PPTABLE].handle, &priv->smu_tables.entry[PPTABLE].mc_addr, &priv->smu_tables.entry[PPTABLE].table); +free_backend: + kfree(hwmgr->smu_backend); + return -EINVAL; }