From: Qinglang Miao Date: Mon, 9 Nov 2020 17:15:18 +0800 Subject: scsi: qedi: Fix missing destroy_workqueue() on error in __qedi_probe Git-commit: 62eebd5247c4e4ce08826ad5995cf4dd7ce919dd Patch-mainline: v5.11-rc1 References: bsc#1186543 Add the missing destroy_workqueue() before return from __qedi_probe in the error handling case when fails to create workqueue qedi->offload_thread. Link: https://lore.kernel.org/r/20201109091518.55941-1-miaoqinglang@huawei.com Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") Reviewed-by: Mike Christie Signed-off-by: Qinglang Miao Signed-off-by: Martin K. Petersen Acked-by: Lee Duncan --- drivers/scsi/qedi/qedi_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -2632,7 +2632,7 @@ static int __qedi_probe(struct pci_dev * QEDI_ERR(&qedi->dbg_ctx, "Unable to start offload thread!\n"); rc = -ENODEV; - goto free_cid_que; + goto free_tmf_thread; } /* F/w needs 1st task context memory entry for performance */ @@ -2652,6 +2652,8 @@ static int __qedi_probe(struct pci_dev * return 0; +free_tmf_thread: + destroy_workqueue(qedi->tmf_thread); free_cid_que: qedi_release_cid_que(qedi); free_uio: