From 95924b65cc5918992cd315639ca8f38a792ebcd0 Mon Sep 17 00:00:00 2001
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
Date: Tue, 3 Oct 2017 16:16:07 -0700
Subject: [PATCH] kernel/sysctl.c: remove duplicate UINT_MAX check on
do_proc_douintvec_conv()
Git-commit: 3181c38e4df257852a0c0a53552fd5c869402886
Patch-mainline: v4.14-rc4
References: bsc#1066470
do_proc_douintvec_conv() has two UINT_MAX checks, we can remove one.
This has no functional changes other than fixing a compiler warning:
kernel/sysctl.c:2190]: (warning) Identical condition '*lvalp>UINT_MAX', second condition is always false
Fixes: 4f2fec00afa60 ("sysctl: simplify unsigned int support")
Link: http://lkml.kernel.org/r/20170919072918.12066-1-mcgrof@kernel.org
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Reported-by: David Binderman <dcb314@hotmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---
kernel/sysctl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/sysctl.c b/kernel/sysctl.c
index fd5ca3bdd096..f1a662103ee3 100644
--- a/kernel/sysctl.c
+++ b/kernel/sysctl.c
@@ -2196,8 +2196,6 @@ static int do_proc_douintvec_conv(unsigned long *lvalp,
int write, void *data)
{
if (write) {
- if (*lvalp > UINT_MAX)
- return -EINVAL;
if (*lvalp > UINT_MAX)
return -EINVAL;
*valp = *lvalp;
--
2.14.2