From: Zheyu Ma <zheyuma97@gmail.com>
Date: Mon, 18 Oct 2021 01:56:21 +0000
Subject: scsi: qla2xxx: Return -ENOMEM if kzalloc() fails
Patch-mainline: v5.15-rc7
Git-commit: 06634d5b6e923ed0d4772aba8def5a618f44c7fe
References: bsc#1195823
The driver probing function should return < 0 for failure, otherwise
kernel will treat value > 0 as success.
Link: https://lore.kernel.org/r/1634522181-31166-1-git-send-email-zheyuma97@gmail.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Daniel Wagner <dwagner@suse.de>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4173,7 +4173,7 @@ qla2x00_mem_alloc(struct qla_hw_data *ha
ql_dbg_pci(ql_dbg_init, ha->pdev,
0xe0ee, "%s: failed alloc dsd\n",
__func__);
- return 1;
+ return -ENOMEM;
}
ha->dif_bundle_kallocs++;