From b91c9cb9d4b378fda65c3196034ecd09ee1493ef Mon Sep 17 00:00:00 2001
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 13 Jul 2020 13:53:24 +0300
Subject: [PATCH] ALSA: echoaudio: re-enable IRQs on failure path
Git-commit: b91c9cb9d4b378fda65c3196034ecd09ee1493ef
Patch-mainline: v5.9-rc1
References: git-fixes
This should be spin_unlock_irq() instead of spin_lock().
Fixes: 6c3312544873 ("ALSA: echoaudio: Prevent races in calls to set_audio_format()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200713105324.GB251988@mwanda
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/pci/echoaudio/echoaudio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/pci/echoaudio/echoaudio.c b/sound/pci/echoaudio/echoaudio.c
index e81f42811f45..6aeb99aa2414 100644
--- a/sound/pci/echoaudio/echoaudio.c
+++ b/sound/pci/echoaudio/echoaudio.c
@@ -721,7 +721,7 @@ static int pcm_prepare(struct snd_pcm_substream *substream)
spin_lock_irq(&chip->lock);
if (snd_BUG_ON(!is_pipe_allocated(chip, pipe_index))) {
- spin_unlock(&chip->lock);
+ spin_unlock_irq(&chip->lock);
return -EINVAL;
}
--
2.16.4