From: James Smart <jsmart2021@gmail.com>
Date: Wed, 7 Jul 2021 11:43:40 -0700
Subject: scsi: lpfc: Fix memory leaks in error paths while issuing ELS RDF/SCR
request
Patch-mainline: v5.15-rc1
Git-commit: cd6047e92c6a5b0a44479cf98f76aac56ddfe108
References: bsc#1189385
The ELS job request structure, that is allocated while issuing ELS RDF/SCR
request path, is not being released in an error path causing a memory leak
message on driver unload.
Free the ELS job structure in the error paths.
Link: https://lore.kernel.org/r/20210707184351.67872-10-jsmart2021@gmail.com
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Daniel Wagner <dwagner@suse.de>
---
drivers/scsi/lpfc/lpfc_els.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -3326,6 +3326,7 @@ lpfc_issue_els_scr(struct lpfc_vport *vp
if (phba->sli_rev == LPFC_SLI_REV4) {
rc = lpfc_reg_fab_ctrl_node(vport, ndlp);
if (rc) {
+ lpfc_els_free_iocb(phba, elsiocb);
lpfc_printf_vlog(vport, KERN_ERR, LOG_NODE,
"0937 %s: Failed to reg fc node, rc %d\n",
__func__, rc);
@@ -3618,6 +3619,7 @@ lpfc_issue_els_rdf(struct lpfc_vport *vp
if (phba->sli_rev == LPFC_SLI_REV4 &&
!(ndlp->nlp_flag & NLP_RPI_REGISTERED)) {
+ lpfc_els_free_iocb(phba, elsiocb);
lpfc_printf_vlog(vport, KERN_ERR, LOG_NODE,
"0939 %s: FC_NODE x%x RPI x%x flag x%x "
"ste x%x type x%x Not registered\n",