From: Ronak Doshi <doshir@vmware.com>
Date: Mon, 1 Jun 2020 20:02:39 -0700
Subject: vmxnet3: allow rx flow hash ops only when rss is enabled
Patch-mainline: v5.8-rc1
Git-commit: 11e877b2a8cfd282a1b81f9d4c594b900889a5d8
References: bsc#1172484
It makes sense to allow changes to get/set rx flow hash callback only
when rss is enabled. This patch restricts get_rss_hash_opts and
set_rss_hash_opts methods to allow querying and configuring different
Rx flow hash configurations only when rss is enabled
Signed-off-by: Ronak Doshi <doshir@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/net/vmxnet3/vmxnet3_ethtool.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
--- a/drivers/net/vmxnet3/vmxnet3_ethtool.c
+++ b/drivers/net/vmxnet3/vmxnet3_ethtool.c
@@ -899,6 +899,12 @@ vmxnet3_get_rxnfc(struct net_device *net
err = -EOPNOTSUPP;
break;
}
+#ifdef VMXNET3_RSS
+ if (!adapter->rss) {
+ err = -EOPNOTSUPP;
+ break;
+ }
+#endif
err = vmxnet3_get_rss_hash_opts(adapter, info);
break;
default:
@@ -919,6 +925,12 @@ vmxnet3_set_rxnfc(struct net_device *net
err = -EOPNOTSUPP;
goto done;
}
+#ifdef VMXNET3_RSS
+ if (!adapter->rss) {
+ err = -EOPNOTSUPP;
+ goto done;
+ }
+#endif
switch (info->cmd) {
case ETHTOOL_SRXFH: