From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Sun, 11 Apr 2021 11:21:40 +0200
Subject: scsi: qla2xxx: Reuse existing error handling path
Patch-mainline: v5.13-rc1
Git-commit: 5dc3468888f8ba54c3a2fdd38b13288f6b8daed2
References: bsc#1185491
There is no need to duplicate code, use the existing error handling path to
free resources. This is more future-proof.
Link: https://lore.kernel.org/r/6973844a1532ec2dc8e86f3533362e79d78ed774.1618132821.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Daniel Wagner <dwagner@suse.de>
---
drivers/scsi/qla2xxx/qla_bsg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -2586,8 +2586,8 @@ qla2x00_get_host_stats(struct bsg_job *b
data = kzalloc(response_len, GFP_KERNEL);
if (!data) {
- kfree(req_data);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto host_stat_out;
}
ret = qla2xxx_get_ini_stats(fc_bsg_to_shost(bsg_job), req_data->stat_type,