From: Saeed Mahameed <saeedm@mellanox.com>
Date: Wed, 7 Feb 2018 20:48:43 -0800
Subject: net/mlx5: Add missing likely/unlikely hints to cq events
Patch-mainline: v4.17-rc1
Git-commit: d2ff4fa575000058def5f5c602784e233211d4e7
References: bsc#1103990 FATE#326006
If a hardware event is targeting a CQ, that CQ should exist.
Add unlikely to error handling flows.
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Reviewed-by: Gal Pressman <galp@mellanox.com>
Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/net/ethernet/mellanox/mlx5/core/cq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/net/ethernet/mellanox/mlx5/core/cq.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/cq.c
@@ -97,7 +97,7 @@ void mlx5_cq_completion(struct mlx5_eq *
refcount_inc(&cq->refcount);
spin_unlock(&table->lock);
- if (!cq) {
+ if (unlikely(!cq)) {
mlx5_core_warn(eq->dev, "Completion event for bogus CQ 0x%x\n", cqn);
return;
}
@@ -118,12 +118,12 @@ void mlx5_cq_event(struct mlx5_eq *eq, u
spin_lock(&table->lock);
cq = radix_tree_lookup(&table->tree, cqn);
- if (cq)
+ if (likely(cq))
refcount_inc(&cq->refcount);
spin_unlock(&table->lock);
- if (!cq) {
+ if (unlikely(!cq)) {
mlx5_core_warn(eq->dev, "Async event for bogus CQ 0x%x\n", cqn);
return;
}