From 60f540389a5d2df25ddc7ad511b4fa2880dea521 Mon Sep 17 00:00:00 2001
From: Petr Mladek <pmladek@suse.com>
Date: Tue, 7 Mar 2023 13:53:33 +0100
Subject: [PATCH] workqueue: Interrupted create_worker() is not a repeated
event
Git-commit: 60f540389a5d2df25ddc7ad511b4fa2880dea521
Patch-mainline: v6.4-rc1
References: bsc#1211044
kthread_create_on_node() might get interrupted(). It is rare but realistic.
For example, when an unbound workqueue is allocated in module_init()
callback. It is done in the context of the "modprobe" process. And,
for example, systemd might kill pending processes when switching root
from initrd to the booted system.
The interrupt is a one-off event and the race might be hard to reproduce.
It is always worth printing.
Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
---
kernel/workqueue.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 9760f0fca82d..5f0ecaaaf997 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -1959,8 +1959,13 @@ static struct worker *create_worker(struct worker_pool *pool)
worker->task = kthread_create_on_node(worker_thread, worker, pool->node,
"kworker/%s", id_buf);
if (IS_ERR(worker->task)) {
- pr_err_once("workqueue: Failed to create a worker thread: %ld",
- PTR_ERR(worker->task));
+ if (PTR_ERR(worker->task) == -EINTR) {
+ pr_err("workqueue: Interrupted when creating a worker thread \"kworker/%s\"\n",
+ id_buf);
+ } else {
+ pr_err_once("workqueue: Failed to create a worker thread: %ld",
+ PTR_ERR(worker->task));
+ }
goto fail;
}
--
2.35.3