From: "David S. Miller" <davem@davemloft.net>
Date: Sun, 5 Aug 2018 12:57:30 -0700
Subject: infiniband: nes: Use skb_peek_next() and skb_queue_walk().
Patch-mainline: v4.20-rc1
Git-commit: 0c69198d81dcf4918d9cf5fe72504eecdd49f839
References: bsc#1109837
Instead of direct SKB list accesses.
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
drivers/infiniband/hw/nes/nes_mgt.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
--- a/drivers/infiniband/hw/nes/nes_mgt.c
+++ b/drivers/infiniband/hw/nes/nes_mgt.c
@@ -197,9 +197,9 @@ static struct sk_buff *nes_get_next_skb(
if (skb) {
/* Continue processing fpdu */
- if (skb->next == (struct sk_buff *)&nesqp->pau_list)
+ skb = skb_peek_next(skb, &nesqp->pau_list);
+ if (!skb)
goto out;
- skb = skb->next;
processacks = false;
} else {
/* Starting a new one */
@@ -552,12 +552,10 @@ static void queue_fpdus(struct sk_buff *
if (skb_queue_len(&nesqp->pau_list) == 0) {
skb_queue_head(&nesqp->pau_list, skb);
} else {
- tmpskb = nesqp->pau_list.next;
- while (tmpskb != (struct sk_buff *)&nesqp->pau_list) {
+ skb_queue_walk(&nesqp->pau_list, tmpskb) {
cb = (struct nes_rskb_cb *)&tmpskb->cb[0];
if (before(seqnum, cb->seqnum))
break;
- tmpskb = tmpskb->next;
}
skb_insert(tmpskb, skb, &nesqp->pau_list);
}