From 3f9e6cd8230a413fdf462aba35ea6b6166fa3631 Mon Sep 17 00:00:00 2001
From: Chris Wilson <chris@chris-wilson.co.uk>
Date: Mon, 25 Sep 2017 13:49:27 +0100
Subject: [PATCH] drm/i915/execlists: Microoptimise execlists_cancel_port_request()
Git-commit: 3f9e6cd8230a413fdf462aba35ea6b6166fa3631
Patch-mainline: v4.15-rc1
References: FATE#322643 bsc#1055900
Just rearrange the code slightly to trim the number of iterations
required.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20170925124929.16974-1-chris@chris-wilson.co.uk
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
---
drivers/gpu/drm/i915/intel_lrc.c | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -571,14 +571,17 @@ done:
execlists_submit_ports(engine);
}
-static void execlist_cancel_port_requests(struct intel_engine_execlists *execlists)
+static void
+execlist_cancel_port_requests(struct intel_engine_execlists *execlists)
{
- unsigned int i;
+ struct execlist_port *port = execlists->port;
+ unsigned int num_ports = ARRAY_SIZE(execlists->port);
- for (i = 0; i < ARRAY_SIZE(execlists->port); i++)
- i915_gem_request_put(port_request(&execlists->port[i]));
-
- memset(execlists->port, 0, sizeof(execlists->port));
+ while (num_ports-- && port_isset(port)) {
+ i915_gem_request_put(port_request(port));
+ memset(port, 0, sizeof(*port));
+ port++;
+ }
}
static void execlists_cancel_requests(struct intel_engine_cs *engine)
@@ -625,7 +628,7 @@ static void execlists_cancel_requests(st
execlists->queue = RB_ROOT;
execlists->first = NULL;
- GEM_BUG_ON(port_isset(&execlists->port[0]));
+ GEM_BUG_ON(port_isset(execlists->port));
/*
* The port is checked prior to scheduling a tasklet, but