From: Zhou Wang <wangzhou1@hisilicon.com>
Date: Wed, 14 Aug 2019 17:28:39 +0800
Subject: crypto: hisilicon - fix error handle in hisi_zip_create_req_q
Git-commit: 1ed2002f891dc1082eb110eaafccfde96d327aa3
Patch-mainline: v5.4-rc1
References: jsc#SLE-16507 jsc#SLE-15835
Directly return error in the first loop in hisi_zip_create_req_q.
Fixes: 62c455ca853e ("crypto: hisilicon - add HiSilicon ZIP accelerator support")
Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/crypto/hisilicon/zip/zip_crypto.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/hisilicon/zip/zip_crypto.c b/drivers/crypto/hisilicon/zip/zip_crypto.c
index 303351325a58..5a3f84dcdcde 100644
--- a/drivers/crypto/hisilicon/zip/zip_crypto.c
+++ b/drivers/crypto/hisilicon/zip/zip_crypto.c
@@ -223,8 +223,10 @@ static int hisi_zip_create_req_q(struct hisi_zip_ctx *ctx)
sizeof(long), GFP_KERNEL);
if (!req_q->req_bitmap) {
ret = -ENOMEM;
- if (i == 1)
- goto err_free_loop0;
+ if (i == 0)
+ return ret;
+
+ goto err_free_loop0;
}
rwlock_init(&req_q->req_lock);
--
2.29.2