From: Tudor Ambarus <tudor.ambarus@microchip.com>
Date: Sat, 2 Nov 2019 11:23:32 +0000
Subject: mtd: spi-nor: Void return type for spi_nor_clear_sr/fsr()
Git-commit: abd494bb071f9d988f5e36499923ab00439dc0d2
Patch-mainline: v5.5-rc1
References: jsc#SLE-14214 jsc#SLE-16606
spi_nor_clear_sr() and spi_nor_clear_fsr() are called just in case
of errors. The callers didn't check their return value, make them
of type void.
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/mtd/spi-nor/spi-nor.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 581329807f0f..f3b4b28f65cc 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -714,7 +714,7 @@ static int s3an_sr_ready(struct spi_nor *nor)
return !!(nor->bouncebuf[0] & XSR_RDY);
}
-static int spi_nor_clear_sr(struct spi_nor *nor)
+static void spi_nor_clear_sr(struct spi_nor *nor)
{
int ret;
@@ -733,8 +733,6 @@ static int spi_nor_clear_sr(struct spi_nor *nor)
if (ret)
dev_dbg(nor->dev, "error %d clearing SR\n", ret);
-
- return ret;
}
static int spi_nor_sr_ready(struct spi_nor *nor)
@@ -758,7 +756,7 @@ static int spi_nor_sr_ready(struct spi_nor *nor)
return !(nor->bouncebuf[0] & SR_WIP);
}
-static int spi_nor_clear_fsr(struct spi_nor *nor)
+static void spi_nor_clear_fsr(struct spi_nor *nor)
{
int ret;
@@ -777,8 +775,6 @@ static int spi_nor_clear_fsr(struct spi_nor *nor)
if (ret)
dev_dbg(nor->dev, "error %d clearing FSR\n", ret);
-
- return ret;
}
static int spi_nor_fsr_ready(struct spi_nor *nor)
--
2.28.0