From: Christoph Hellwig <hch@lst.de>
Date: Mon, 28 Sep 2020 12:30:16 +0200
Subject: nvme: revalidate zone bitmaps in nvme_update_ns_info
Patch-mainline: v5.10-rc1
Git-commit: 3a9967ba7ace91153f9caa8e60a55c7668c7b946
References: bsc#1180197
Consolidate the two calls into a single place.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Acked-by: Daniel Wagner <dwagner@suse.de>
---
drivers/nvme/host/core.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2150,6 +2150,12 @@ static int nvme_update_ns_info(struct nv
nvme_update_disk_info(ns->disk, ns, id);
blk_mq_unfreeze_queue(ns->disk->queue);
+ if (blk_queue_is_zoned(ns->queue)) {
+ ret = nvme_revalidate_zones(ns);
+ if (ret)
+ return ret;
+ }
+
#ifdef CONFIG_NVME_MULTIPATH
if (ns->head->disk) {
blk_mq_freeze_queue(ns->head->disk->queue);
@@ -3938,8 +3944,6 @@ static void nvme_alloc_ns(struct nvme_ct
if (nvme_update_ns_info(ns, id))
goto out_put_disk;
- if (blk_queue_is_zoned(ns->queue) && nvme_revalidate_zones(ns))
- goto out_put_disk;
if ((ctrl->quirks & NVME_QUIRK_LIGHTNVM) && id->vs[0] == 0x1) {
ret = nvme_nvm_register(ns, disk_name, node);
@@ -4035,8 +4039,6 @@ static void nvme_validate_or_alloc_ns(st
}
ret = nvme_validate_ns(ns);
- if (!ret && blk_queue_is_zoned(ns->queue))
- ret = nvme_revalidate_zones(ns);
revalidate_disk_size(ns->disk, ret == 0);
if (ret)
nvme_ns_remove(ns);