From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Tue, 21 Apr 2020 17:20:00 +0200
Subject: s390/qdio: remove always-true condition
Git-commit: 19d4c761c1d2354e6c1deb6e1d31c949028b92d6
Patch-mainline: v5.8-rc1
References: jsc#SLE-13690
buf_in_between() gets passed q->u.in.ack_start as 'bufnr' parameter.
The ack_start always ranges between 0 and QDIO_MAX_BUFFERS_PER_Q - 1,
so the subsequent check will always return true. Remove it.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Acked-by: Petr Tesarik <ptesarik@suse.com>
---
drivers/s390/cio/qdio_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/s390/cio/qdio_main.c b/drivers/s390/cio/qdio_main.c
index 68985871b6bf..4bd6dbfe8387 100644
--- a/drivers/s390/cio/qdio_main.c
+++ b/drivers/s390/cio/qdio_main.c
@@ -1450,8 +1450,7 @@ static inline int buf_in_between(int bufnr, int start, int count)
}
/* wrap-around case */
- if ((bufnr >= start && bufnr <= QDIO_MAX_BUFFERS_PER_Q) ||
- (bufnr < end))
+ if (bufnr >= start || bufnr < end)
return 1;
else
return 0;