From: Jens Axboe <axboe@kernel.dk>
Date: Thu, 14 Oct 2021 09:15:40 -0600
Subject: [PATCH] block: remove useless caller argument to print_req_error()
Git-commit: c477b7977838ac97dd9d20625591a5d23c8079b7
Patch-mainline: v5.16-rc1
References: jsc#PED-1183
We have exactly one caller of this, just get rid of adding the useless
function name to the output.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Hannes Reinecke <hare@suse.com>
---
block/blk-core.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 96ee996c0577..b4094b31c99c 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -216,8 +216,7 @@ int blk_status_to_errno(blk_status_t status)
}
EXPORT_SYMBOL_GPL(blk_status_to_errno);
-static void print_req_error(struct request *req, blk_status_t status,
- const char *caller)
+static void print_req_error(struct request *req, blk_status_t status)
{
int idx = (__force int)status;
@@ -225,9 +224,9 @@ static void print_req_error(struct request *req, blk_status_t status,
return;
printk_ratelimited(KERN_ERR
- "%s: %s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
+ "%s error, dev %s, sector %llu op 0x%x:(%s) flags 0x%x "
"phys_seg %u prio class %u\n",
- caller, blk_errors[idx].name,
+ blk_errors[idx].name,
req->rq_disk ? req->rq_disk->disk_name : "?",
blk_rq_pos(req), req_op(req), blk_op_str(req_op(req)),
req->cmd_flags & ~REQ_OP_MASK,
@@ -1471,7 +1470,7 @@ bool blk_update_request(struct request *req, blk_status_t error,
if (unlikely(error && !blk_rq_is_passthrough(req) &&
!(req->rq_flags & RQF_QUIET)))
- print_req_error(req, error, __func__);
+ print_req_error(req, error);
blk_account_io_completion(req, nr_bytes);
--
2.35.3