From a2cb66b476e282b4fc1ce8b69f1fae0f9991d0b6 Mon Sep 17 00:00:00 2001
From: Armin Wolf <W_Armin@gmx.de>
Date: Thu, 29 Jul 2021 00:15:54 +0200
Subject: [PATCH] hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Git-commit: a2cb66b476e282b4fc1ce8b69f1fae0f9991d0b6
References: git-fixes
Patch-mainline: v5.15-rc1
Use devm_add_action_or_reset() for calling i8k_exit_procfs()
so the remove() function in dell_smm_driver can be omitted.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Pali Rohár <pali@kernel.org>
Tested-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20210728221557.8891-4-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
drivers/hwmon/dell-smm-hwmon.c | 28 +++++++++-------------------
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index c898d6bd6a18..da7040f2442e 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -605,24 +605,22 @@ static const struct proc_ops i8k_proc_ops = {
.proc_ioctl = i8k_ioctl,
};
-static void __init i8k_init_procfs(void)
+static void i8k_exit_procfs(void *param)
{
- /* Register the proc entry */
- proc_create("i8k", 0, NULL, &i8k_proc_ops);
+ remove_proc_entry("i8k", NULL);
}
-static void __exit i8k_exit_procfs(void)
+static void __init i8k_init_procfs(struct device *dev)
{
- remove_proc_entry("i8k", NULL);
+ /* Register the proc entry */
+ proc_create("i8k", 0, NULL, &i8k_proc_ops);
+
+ devm_add_action_or_reset(dev, i8k_exit_procfs, NULL);
}
#else
-static inline void __init i8k_init_procfs(void)
-{
-}
-
-static inline void __exit i8k_exit_procfs(void)
+static void __init i8k_init_procfs(struct device *dev)
{
}
@@ -1287,14 +1285,7 @@ static int __init dell_smm_probe(struct platform_device *pdev)
if (ret)
return ret;
- i8k_init_procfs();
-
- return 0;
-}
-
-static int dell_smm_remove(struct platform_device *pdev)
-{
- i8k_exit_procfs();
+ i8k_init_procfs(&pdev->dev);
return 0;
}
@@ -1303,7 +1294,6 @@ static struct platform_driver dell_smm_driver = {
.driver = {
.name = KBUILD_MODNAME,
},
- .remove = dell_smm_remove,
};
static struct platform_device *dell_smm_device;
--
2.26.2