From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date: Thu, 26 Mar 2020 16:58:05 +0100
Subject: [PATCH] ata: remove EXPORT_SYMBOL_GPL()s not used by modules
Git-commit: 2b67a6d3a4d2f630cd5e29b4bfe21a697585eaf8
Patch-mainline: v5.7-rc1
References: bsc#1175995,jsc#SLE-15608
Remove EXPORT_SYMBOL_GPL()s for functions used only by
the core libata code.
Code size savings on m68k arch using (modified) atari_defconfig:
text data bss dec hex filename
before:
39838 573 40 40451 9e03 drivers/ata/libata-core.o
21071 105 576 21752 54f8 drivers/ata/libata-scsi.o
17519 18 0 17537 4481 drivers/ata/libata-eh.o
after:
39688 573 40 40301 9d6d drivers/ata/libata-core.o
21040 105 576 21721 54d9 drivers/ata/libata-scsi.o
17405 18 0 17423 440f drivers/ata/libata-eh.o
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Acked-by: Hannes Reinecke <hare@suse.com>
---
drivers/ata/libata-core.c | 5 -----
drivers/ata/libata-eh.c | 4 ----
drivers/ata/libata-scsi.c | 1 -
3 files changed, 10 deletions(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index dc48e983ccdb..2ec1a49388ee 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -80,7 +80,6 @@ const struct ata_port_operations ata_base_port_ops = {
.sched_eh = ata_std_sched_eh,
.end_eh = ata_std_end_eh,
};
-EXPORT_SYMBOL_GPL(ata_base_port_ops);
const struct ata_port_operations sata_port_ops = {
.inherits = &ata_base_port_ops,
@@ -902,7 +901,6 @@ void ata_unpack_xfermask(unsigned long xfer_mask, unsigned long *pio_mask,
if (udma_mask)
*udma_mask = (xfer_mask & ATA_MASK_UDMA) >> ATA_SHIFT_UDMA;
}
-EXPORT_SYMBOL_GPL(ata_unpack_xfermask);
static const struct ata_xfer_ent {
int shift, bits;
@@ -3425,7 +3423,6 @@ u8 ata_timing_cycle2mode(unsigned int xfer_shift, int cycle)
return last_mode;
}
-EXPORT_SYMBOL_GPL(ata_timing_cycle2mode);
/**
* ata_down_xfermask_limit - adjust dev xfer masks downward
@@ -5051,7 +5048,6 @@ void ata_sg_init(struct ata_queued_cmd *qc, struct scatterlist *sg,
qc->n_elem = n_elem;
qc->cursg = qc->sg;
}
-EXPORT_SYMBOL_GPL(ata_sg_init);
#ifdef CONFIG_HAS_DMA
@@ -6157,7 +6153,6 @@ void ata_host_get(struct ata_host *host)
{
kref_get(&host->kref);
}
-EXPORT_SYMBOL_GPL(ata_host_get);
void ata_host_put(struct ata_host *host)
{
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 1d231cfab26f..04275f4c8d36 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1215,7 +1215,6 @@ void ata_eh_thaw_port(struct ata_port *ap)
DPRINTK("ata%u port thawed\n", ap->print_id);
}
-EXPORT_SYMBOL_GPL(ata_eh_thaw_port);
static void ata_eh_scsidone(struct scsi_cmnd *scmd)
{
@@ -1250,7 +1249,6 @@ void ata_eh_qc_complete(struct ata_queued_cmd *qc)
scmd->retries = scmd->allowed;
__ata_eh_qc_complete(qc);
}
-EXPORT_SYMBOL_GPL(ata_eh_qc_complete);
/**
* ata_eh_qc_retry - Tell midlayer to retry an ATA command after EH
@@ -1270,7 +1268,6 @@ void ata_eh_qc_retry(struct ata_queued_cmd *qc)
scmd->allowed++;
__ata_eh_qc_complete(qc);
}
-EXPORT_SYMBOL_GPL(ata_eh_qc_retry);
/**
* ata_dev_disable - disable ATA device
@@ -4041,7 +4038,6 @@ void ata_do_eh(struct ata_port *ap, ata_prereset_fn_t prereset,
ata_eh_finish(ap);
}
-EXPORT_SYMBOL_GPL(ata_do_eh);
/**
* ata_std_error_handler - standard error handler
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 24024e728296..ae63ef7adcb9 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4536,7 +4536,6 @@ void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd)
cmd->scsi_done(cmd);
}
-EXPORT_SYMBOL_GPL(ata_scsi_simulate);
int ata_scsi_add_hosts(struct ata_host *host, struct scsi_host_template *sht)
{
--
2.16.4