Blob Blame History Raw
From ab16f54ef3cdb6bbc06a36f636a89e6db8a6cea3 Mon Sep 17 00:00:00 2001
From: Christophe Kerello <christophe.kerello@st.com>
Date: Tue, 21 Jul 2020 11:52:07 +0200
Subject: [PATCH] mtd: rawnand: stm32_fmc2: fix a buffer overflow
Git-commit: ab16f54ef3cdb6bbc06a36f636a89e6db8a6cea3
Patch-mainline: v5.10-rc1
References: git-fixes

This patch solves following static checker warning:
drivers/mtd/nand/raw/stm32_fmc2_nand.c:350 stm32_fmc2_nfc_select_chip()
Error: buffer overflow 'nfc->data_phys_addr' 2 <= 2

The CS value can only be 0 or 1.

Signed-off-by: Christophe Kerello <christophe.kerello@st.com>
Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/1595325127-32693-1-git-send-email-christophe.kerello@st.com
Acked-by: Takashi Iwai <tiwai@suse.de>

---
 drivers/mtd/nand/raw/stm32_fmc2_nand.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c
+++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c
@@ -1811,7 +1811,7 @@ static int stm32_fmc2_parse_child(struct
 			return ret;
 		}
 
-		if (cs > FMC2_MAX_CE) {
+		if (cs >= FMC2_MAX_CE) {
 			dev_err(fmc2->dev, "invalid reg value: %d\n", cs);
 			return -EINVAL;
 		}