From: Tobias Klauser <tklauser@distanz.ch>
Date: Wed, 10 Jun 2020 15:08:04 +0200
Subject: tools, bpftool: Fix memory leak in codegen error cases
Patch-mainline: v5.8-rc1
Git-commit: d4060ac969563113101c79433f2ae005feca1c29
References: bsc#1177028
Free the memory allocated for the template on error paths in function
codegen.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20200610130804.21423-1-tklauser@distanz.ch
Acked-by: Gary Lin <glin@suse.com>
---
tools/bpf/bpftool/gen.c | 2 ++
1 file changed, 2 insertions(+)
--- a/tools/bpf/bpftool/gen.c
+++ b/tools/bpf/bpftool/gen.c
@@ -224,6 +224,7 @@ static int codegen(const char *template,
} else {
p_err("unrecognized character at pos %td in template '%s'",
src - template - 1, template);
+ free(s);
return -EINVAL;
}
}
@@ -234,6 +235,7 @@ static int codegen(const char *template,
if (*src != '\t') {
p_err("not enough tabs at pos %td in template '%s'",
src - template - 1, template);
+ free(s);
return -EINVAL;
}
}