From 789d027ec8e7aa300689f418b522ae21e333eb17 Mon Sep 17 00:00:00 2001
From: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Date: Thu, 15 Aug 2019 12:35:39 -0400
Subject: drm/amd/display: fix calc_pll_max_vco_construct
Git-commit: 789d027ec8e7aa300689f418b522ae21e333eb17
Patch-mainline: v5.4-rc1
References: bsc#1152489
This was broken by a previous change switching to cached fw_info.
Fixed by inverting a valid bool check.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=111432
Fixes: 9adc8050bf3c ("drm/amd/display: make firmware info only load once during dc_bios create")
Signed-off-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
index 926954c804a6..f787a6b94781 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
@@ -1241,7 +1241,7 @@ static bool calc_pll_max_vco_construct(
init_data->bp == NULL)
return false;
- if (init_data->bp->fw_info_valid)
+ if (!init_data->bp->fw_info_valid)
return false;
fw_info = &init_data->bp->fw_info;
--
2.28.0