From 121bdbf113c70ab7eb1efa94e3c60352a5b81b49 Mon Sep 17 00:00:00 2001
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Sat, 28 Apr 2018 17:47:49 +0200
Subject: [PATCH] staging: vc04_services: Remove stack hog issue from TODO
Git-commit: 121bdbf113c70ab7eb1efa94e3c60352a5b81b49
Patch-mainline: v4.18-rc1
References: FATE#324827
Since there is no vchiq function listed by "make checkstack" anymore,
we can remove the stack hog issue from the TODO.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Takashi Iwai <tiwai@suse.de>
---
drivers/staging/vc04_services/interface/vchi/TODO | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
--- a/drivers/staging/vc04_services/interface/vchi/TODO
+++ b/drivers/staging/vc04_services/interface/vchi/TODO
@@ -40,17 +40,12 @@ should properly handle a module unload.
resouces must be freed (kthreads, debugfs entries, ...) and global
variables avoided.
-5) Fix stack hog
-
-Running make checkstack shows that vchiq_dump_service_use_state() has
-an extensive stack usage. Maybe other functions are also affected.
-
-6) Cleanup logging mechanism
+5) Cleanup logging mechanism
The driver should probably be using the standard kernel logging mechanisms
such as dev_info, dev_dbg, and friends.
-7) Documentation
+6) Documentation
A short top-down description of this driver's architecture (function of
kthreads, userspace, limitations) could be very helpful for reviewers.