Blob Blame History Raw
From 8c13212443230d03ff25014514ec0d53498c0912 Mon Sep 17 00:00:00 2001
From: Jiajun Cao <jjcao20@fudan.edu.cn>
Date: Tue, 22 Jun 2021 21:19:42 +0800
Subject: [PATCH] ALSA: hda: Add IRQ check for platform_get_irq()
Git-commit: 8c13212443230d03ff25014514ec0d53498c0912
Patch-mainline: v5.14-rc1
References: git-fixes

The function hda_tegra_first_init() neglects to check the return
value after executing platform_get_irq().

hda_tegra_first_init() should check the return value (if negative
error number) for errors so as to not pass a negative value to
the devm_request_irq().

Fix it by adding a check for the return value irq_id.

Signed-off-by: Jiajun Cao <jjcao20@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20210622131947.94346-1-jjcao20@fudan.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>

---
 sound/pci/hda/hda_tegra.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/sound/pci/hda/hda_tegra.c
+++ b/sound/pci/hda/hda_tegra.c
@@ -350,6 +350,9 @@ static int hda_tegra_first_init(struct a
 	const char *sname;
 	struct device_node *root;
 
+	if (irq_id < 0)
+		return irq_id;
+
 	err = hda_tegra_init_chip(chip, pdev);
 	if (err)
 		return err;