From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 12 Oct 2017 23:30:57 +0300
Subject: scsi: lpfc: Fix a precedence bug in lpfc_nvme_io_cmd_wqe_cmpl()
Patch-mainline: v4.15-rc1
Git-commit: 41319e4f62f28aeb36ad6b51a58cec5e76884ebb
References: bsc#1050239,FATE#322918
The ! has higher precedence than the & operation. I've added
parenthesis so this works as intended.
Fixes: 952c303b329c ("scsi: lpfc: Ensure io aborts interlocked with the target.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Acked-by: Johannes Thumshirn <jthumshirn@suse.de>
---
drivers/scsi/lpfc/lpfc_nvme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
index ea2a41022ace..db1ed426f7e6 100644
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/drivers/scsi/lpfc/lpfc_nvme.c
@@ -948,7 +948,7 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
/* NVME targets need completion held off until the abort exchange
* completes.
*/
- if (!lpfc_ncmd->flags & LPFC_SBUF_XBUSY)
+ if (!(lpfc_ncmd->flags & LPFC_SBUF_XBUSY))
nCmd->done(nCmd);
spin_lock_irqsave(&phba->hbalock, flags);
--
2.12.3