From 91cdfd1761659f338e673aca72af3d0d50b88847 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <hch@lst.de>
Date: Wed, 11 Jul 2018 22:25:58 -0700
Subject: [PATCH] xfs: do not set the page uptodate in xfs_writepage_map
Git-commit: 91cdfd1761659f338e673aca72af3d0d50b88847
Patch-mainline: v4.19-rc1
References: bsc#1138003
We already track the page uptodate status based on the buffer uptodate
status, which is updated whenever reading or zeroing blocks.
This code has been there since commit a ptool commit in 2002, which
claims to:
"merge" the 2.4 fsx fix for block size < page size to 2.5. This needed
major changes to actually fit.
and isn't present in other writepage implementations.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: Anthony Iliopoulos <ailiopoulos@suse.com>
---
fs/xfs/xfs_aops.c | 6 ------
1 file changed, 6 deletions(-)
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -928,7 +928,6 @@
uint64_t offset;
int error = 0;
int count = 0;
- int uptodate = 1;
unsigned int new_type;
bh = head = page_buffers(page);
@@ -936,8 +935,6 @@
do {
if (offset >= end_offset)
break;
- if (!buffer_uptodate(bh))
- uptodate = 0;
/*
* set_page_dirty dirties all buffers in a page, independent
@@ -1001,9 +998,6 @@
} while (offset += len, ((bh = bh->b_this_page) != head));
- if (uptodate && bh == head)
- SetPageUptodate(page);
-
ASSERT(wpc->ioend || list_empty(&submit_list));
out: