From: Leon Romanovsky <leonro@nvidia.com>
Date: Sun, 28 Nov 2021 14:14:46 +0200
Subject: devlink: Remove misleading internal_flags from health reporter dump
Patch-mainline: v5.17-rc1
Git-commit: e9538f8270db24d272659e15841854c7ea11119e
References: jsc#PED-1495
DEVLINK_CMD_HEALTH_REPORTER_DUMP_GET command doesn't have .doit callback
and has no use in internal_flags at all. Remove this misleading assignment.
Fixes: e44ef4e4516c ("devlink: Hang reporter's dump method on a dumpit cb")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
---
net/core/devlink.c | 2 --
1 file changed, 2 deletions(-)
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -8883,8 +8883,6 @@ static const struct genl_small_ops devli
GENL_DONT_VALIDATE_DUMP_STRICT,
.dumpit = devlink_nl_cmd_health_reporter_dump_get_dumpit,
.flags = GENL_ADMIN_PERM,
- .internal_flags = DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT |
- DEVLINK_NL_FLAG_NO_LOCK,
},
{
.cmd = DEVLINK_CMD_HEALTH_REPORTER_DUMP_CLEAR,