From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Wed, 6 Mar 2024 08:30:46 +0300
Subject: RAS/AMD/FMPM: Fix off by one when unwinding on error
Git-commit: bd17b7c34fadef645becde1245b9394f69f31702
Patch-mainline: v6.9-rc1
References: jsc#PED-7619
Decrement the index variable i before the first iteration when freeing
the remaining elements on error. Depending on where this fails it could
free something from one element beyond the end of the fru_records[]
array.
[ bp: Massage commit message. ]
Fixes: 6f15e617cc99 ("RAS: Introduce a FRU memory poison manager")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/6fdec71a-846b-4cd0-af69-e5f6cd12f4f6@moroto.mountain
Acked-by: Nikolay Borisov <nik.borisov@suse.com>
---
drivers/ras/amd/fmpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
index 0963c9e7b853..2f4ac9591c8f 100644
--- a/drivers/ras/amd/fmpm.c
+++ b/drivers/ras/amd/fmpm.c
@@ -817,7 +817,7 @@ static int allocate_records(void)
return ret;
out_free:
- for (; i >= 0; i--)
+ while (--i >= 0)
kfree(fru_records[i]);
kfree(fru_records);