From 3c252b087de08d3cb32468b54a158bd7ad0ae2f7 Mon Sep 17 00:00:00 2001
From: Chung-Chiang Cheng <shepjeng@gmail.com>
Date: Fri, 18 Jun 2021 15:59:25 +0800
Subject: [PATCH] configfs: fix memleak in configfs_release_bin_file
Git-commit: 3c252b087de08d3cb32468b54a158bd7ad0ae2f7
Patch-mainline: v5.14-rc1
References: git-fixes
When reading binary attributes in progress, buffer->bin_buffer is setup in
configfs_read_bin_file() but never freed.
Fixes: 03607ace807b4 ("configfs: implement binary attributes")
Signed-off-by: Chung-Chiang Cheng <cccheng@synology.com>
[hch: move the vfree rather than duplicating it]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Anthony Iliopoulos <ailiop@suse.com>
---
fs/configfs/file.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/configfs/file.c b/fs/configfs/file.c
index 53913b84383a..396418333513 100644
--- a/fs/configfs/file.c
+++ b/fs/configfs/file.c
@@ -407,13 +407,13 @@ static int configfs_release_bin_file(struct inode *inode, struct file *file)
buffer->bin_buffer_size);
}
up_read(&frag->frag_sem);
- /* vfree on NULL is safe */
- vfree(buffer->bin_buffer);
- buffer->bin_buffer = NULL;
- buffer->bin_buffer_size = 0;
- buffer->needs_read_fill = 1;
}
+ vfree(buffer->bin_buffer);
+ buffer->bin_buffer = NULL;
+ buffer->bin_buffer_size = 0;
+ buffer->needs_read_fill = 1;
+
configfs_release(inode, file);
return 0;
}
--
2.43.0