From 583b4c03b665180a40bf390557ef8ef31e3db0ac Mon Sep 17 00:00:00 2001
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 20 Nov 2019 19:19:07 -0800
Subject: [PATCH 1/3] net-sysfs: fix netdev_queue_add_kobject() breakage
Git-commit: 48a322b6f9965b2f1e4ce81af972f0e287b07ed0
Patch-mainline: v5.4
References: git-fixes
kobject_put() should only be called in error path.
Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jouni Hogander <jouni.hogander@unikie.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Denis Kirjanov <denis.kirjanov@suse.com>
---
net/core/net-sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 5b8866bcd45b..0cde5f96f622 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1433,6 +1433,7 @@ static int netdev_queue_add_kobject(struct net_device *dev, int index)
#endif
kobject_uevent(kobj, KOBJ_ADD);
+ return 0;
err:
kobject_put(kobj);
--
2.16.4