From: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Date: Fri, 18 Nov 2022 14:31:37 +0800
Subject: perf/x86/intel/uncore: Fix reference count leak in
__uncore_imc_init_box()
Git-commit: 17b8d847b92d815d1638f0de154654081d66b281
Patch-mainline: v6.2-rc1
References: jsc#PED-5023 bsc#1211439 (git-fixes)
X-Info: adjust for context, no "Add IMC uncore support for ADL" 5a4487f9ef5ef2fdb3215cadf0a9c3e5e8678634; no "Record the size of mapped area" 1b94d31de422399421422af0e63c9685e7485901
pci_get_device() will increase the reference count for the returned
pci_dev, so tgl_uncore_get_mc_dev() will return a pci_dev with its
reference count increased. We need to call pci_dev_put() to decrease the
reference count before exiting from __uncore_imc_init_box(). Add
pci_dev_put() for both normal and error path.
Fixes: fdb64822443e ("perf/x86: Add Intel Tiger Lake uncore support")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Link: https://lore.kernel.org/r/20221118063137.121512-5-wangxiongfeng2@huawei.com
Signed-off-by: Tony Jones <tonyj@suse.de>
---
arch/x86/events/intel/uncore_snb.c | 3 +++
1 file changed, 3 insertions(+)
--- a/arch/x86/events/intel/uncore_snb.c
+++ b/arch/x86/events/intel/uncore_snb.c
@@ -1236,6 +1236,7 @@
/* MCHBAR is disabled */
if (!(mch_bar & BIT(0))) {
pr_warn("perf uncore: MCHBAR is disabled. Failed to map IMC free-running counters.\n");
+ pci_dev_put(pdev);
return;
}
mch_bar &= ~BIT(0);
@@ -1247,6 +1248,8 @@
#endif
box->io_addr = ioremap(addr, TGL_UNCORE_PCI_IMC_MAP_SIZE);
+
+ pci_dev_put(pdev);
}
static struct intel_uncore_ops tgl_uncore_imc_freerunning_ops = {