Blob Blame History Raw
From: Trond Myklebust <trondmy@gmail.com>
Date: Thu, 17 Oct 2019 09:02:20 -0400
Subject: [PATCH] SUNRPC: The RDMA back channel mustn't disappear while
 requests are outstanding
Git-commit: 9edb455e6797bb50aa38ef71e62668966065ede8
Patch-mainline: v5.4
References: git-fixes

If there are RDMA back channel requests being processed by the
server threads, then we should hold a reference to the transport
to ensure it doesn't get freed from underneath us.

Reported-by: Neil Brown <neilb@suse.de>
Fixes: 63cae47005af ("xprtrdma: Handle incoming backward direction RPC calls")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Acked-by: NeilBrown <neilb@suse.com>

---
 net/sunrpc/xprtrdma/backchannel.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/net/sunrpc/xprtrdma/backchannel.c
+++ b/net/sunrpc/xprtrdma/backchannel.c
@@ -257,6 +257,7 @@ void xprt_rdma_bc_free_rqst(struct rpc_r
 	spin_lock_bh(&xprt->bc_pa_lock);
 	list_add_tail(&rqst->rq_bc_pa_list, &xprt->bc_pa_list);
 	spin_unlock_bh(&xprt->bc_pa_lock);
+	xprt_put(xprt);
 }
 
 /**
@@ -325,6 +326,7 @@ void rpcrdma_bc_receive_call(struct rpcr
 
 	/* Queue rqst for ULP's callback service */
 	bc_serv = xprt->bc_serv;
+	xprt_get(xprt);
 	spin_lock(&bc_serv->sv_cb_lock);
 	list_add(&rqst->rq_bc_list, &bc_serv->sv_cb_list);
 	spin_unlock(&bc_serv->sv_cb_lock);