Blob Blame History Raw
From b7a4f80bc316a56d6ec8750e93e66f42431ed960 Mon Sep 17 00:00:00 2001
From: "dinghao.liu@zju.edu.cn" <dinghao.liu@zju.edu.cn>
Date: Thu, 20 Aug 2020 14:38:17 +0800
Subject: [PATCH] backlight: sky81452-backlight: Fix refcount imbalance on error
Git-commit: b7a4f80bc316a56d6ec8750e93e66f42431ed960
Patch-mainline: v5.10-rc1
References: git-fixes

When of_property_read_u32_array() returns an error code, a
pairing refcount decrement is needed to keep np's refcount
balanced.

Fixes: f705806c9f355 ("backlight: Add support Skyworks SKY81452 backlight driver")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Takashi Iwai <tiwai@suse.de>

---
 drivers/video/backlight/sky81452-backlight.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
index 0ce181585008..8268ac43d54f 100644
--- a/drivers/video/backlight/sky81452-backlight.c
+++ b/drivers/video/backlight/sky81452-backlight.c
@@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt(
 					num_entry);
 		if (ret < 0) {
 			dev_err(dev, "led-sources node is invalid.\n");
+			of_node_put(np);
 			return ERR_PTR(-EINVAL);
 		}
 
-- 
2.16.4