From 1211229399b3f9b8b0e337c898efb09695f71c91 Mon Sep 17 00:00:00 2001
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Thu, 19 Apr 2018 08:24:29 -0500
Subject: [PATCH] ipmi_ssif: Fix uninitialized variable issue
Git-commit: 1211229399b3f9b8b0e337c898efb09695f71c91
Patch-mainline: v4.18-rc1
References: FATE#326156
Currently, function ssif_remove returns _rv_, which is a variable that
is never initialized.
Fix this by removing variable _rv_ and return 0 instead.
Addresses-coverity-id: 1467999 ("Uninitialized scalar variable")
Fixes: 6a0d23ed338e ("ipmi: ipmi_unregister_smi() cannot fail, have it
return void")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Acked-by: Takashi Iwai <tiwai@suse.de>
---
drivers/char/ipmi/ipmi_ssif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index ecabfe27c828..37f9ae2de6a4 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1227,7 +1227,6 @@ static int ssif_remove(struct i2c_client *client)
struct ssif_info *ssif_info = i2c_get_clientdata(client);
struct ipmi_smi *intf;
struct ssif_addr_info *addr_info;
- int rv;
if (!ssif_info)
return 0;
@@ -1247,7 +1246,7 @@ static int ssif_remove(struct i2c_client *client)
}
}
- return rv;
+ return 0;
}
static int do_cmd(struct i2c_client *client, int len, unsigned char *msg,
--
2.19.2