From: James Smart <jsmart2021@gmail.com>
Date: Fri, 18 Oct 2019 14:18:23 -0700
Subject: scsi: lpfc: fix coverity error of dereference after null check
Patch-mainline: v5.5-rc1
Git-commit: f84f8f93f01feb64fdda8dd6c72d1b7dc24ad11d
References: bsc#1154521
Log message conditional upon vport being NULL dereferences vport
to determine log verbose setting.
Changed to use lpfc_print_log which uses phba to determine the
active log verbose setting.
Fixes: 43bfea1bffb6 ("scsi: lpfc: Fix coverity errors on NULL pointer checks")
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Acked-by: Daniel Wagner <dwagner@suse.de>
---
drivers/scsi/lpfc/lpfc_els.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index da90c7bf2287..2235a45999a8 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4292,8 +4292,8 @@ lpfc_cmpl_els_rsp(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
irsp = &rspiocb->iocb;
if (!vport) {
- lpfc_printf_vlog(vport, KERN_ERR, LOG_ELS,
- "3177 ELS response failed\n");
+ lpfc_printf_log(phba, KERN_ERR, LOG_ELS,
+ "3177 ELS response failed\n");
goto out;
}
if (cmdiocb->context_un.mbox)
--
2.16.4