Blob Blame History Raw
From e5c9d1107a07c871c3ce0f55b7c175e043581900 Mon Sep 17 00:00:00 2001
From: Keerthi Reddy <keerthigd4990@gmail.com>
Date: Thu, 28 Sep 2017 20:28:40 +0530
Subject: [PATCH] Staging: vc04_services: remove unused variables
Git-commit: e5c9d1107a07c871c3ce0f55b7c175e043581900
Patch-mainline: v4.15-rc1
References: FATE#324827

the volatile fields of bcm2835_alsa_stream -
control and status are not used.

$ grep bcm2835_alsa_stream
>From the above command all instances we see that
all variables of 'bcm2835_alsa_stream' are declared as
'alsa_stream'

So search for 'control' wherever we have 'alsa_stream'

$ grep -l 'alsa_stream' | xargs grep "control"
The above command returns where we don't any usage of
'control' field. which means that there is no usage of
these fields.

similarly for 'status' we see no usages.

Signed-off-by: Keerthi Reddy <keerthigd4990@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Takashi Iwai <tiwai@suse.de>

---
 drivers/staging/vc04_services/bcm2835-audio/bcm2835.h |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.h
@@ -123,8 +123,6 @@ struct bcm2835_alsa_stream {
 	struct snd_pcm_indirect pcm_indirect;
 
 	spinlock_t lock;
-	volatile unsigned int control;
-	volatile unsigned int status;
 
 	int open;
 	int running;