From: Al Viro <viro@zeniv.linux.org.uk>
Date: Mon, 14 May 2018 21:26:32 -0400
Subject: [PATCH] cifs_lookup(): cifs_get_inode_...() never returns 0 with
 *inode left NULL
Git-commit: a8b75f663ee825ab9d75839482bb12198faee70d
Patch-mainline: v4.17-rc7
References: bsc#1144333

not since 2004...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Aurelien Aptel <aaptel@suse.com>
---
 fs/cifs/dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index 81ba6e0d88d8..ecbf36c459ea 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -812,7 +812,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
 				parent_dir_inode->i_sb, xid, NULL);
 	}
 
-	if ((rc == 0) && (newInode != NULL)) {
+	if (rc == 0) {
 		d_add(direntry, newInode);
 		/* since paths are not looked up by component - the parent
 		   directories are presumed to be good here */
-- 
2.16.4