From: Julian Wiedmann <jwi@linux.ibm.com>
Subject: s390/qeth: tidy up parameter naming for qeth_do_send_packet()
Patch-mainline: v4.15-rc1
Git-commit: e878c5e6003edae23512fe43d3c050622e5ebcf5
References: FATE#326350, LTC#169511, bsc#1113509

Summary:     qeth: performance improvements
Description: This adds recent functional and performance improvements for the
             qeth network driver.
             Primarily this brings Scatter-Gather support for HiperSockets,
             reduced CPU consumption in the L3 IPv4 transmit path for OSA,
             improved Promiscuous Mode performance due to IFF_UNICAST_FLT,
             support for Scatter-Gather on z/VM virtual NICs, and
             support for delayed GRO flushing.

             For sanity & stability reasons, this effectively constitutes a
             backport of the qeth device driver from 4.19 mainline.
             

Upstream-Description:

             s390/qeth: tidy up parameter naming for qeth_do_send_packet()

             Cppcheck reports the following for drivers/s390/net/qeth_core.h:

                 warning - line 1560 - Function 'qeth_do_send_packet' argument order
                 different:
                 declaration 'card, queue, skb, hdr, hd_len, offset, elements'
                 definition  'card, queue, skb, hdr, offset, hd_len, elements_needed'.

             Match the naming in the function's declaration against its definition.

             Signed-off-by: Jens Remus <jremus@linux.vnet.ibm.com>
             Reviewed-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
             Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com>
             Signed-off-by: David S. Miller <davem@davemloft.net>

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Acked-by: Petr Tesarik <ptesarik@suse.com>
---
 drivers/s390/net/qeth_core.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/s390/net/qeth_core.h
+++ b/drivers/s390/net/qeth_core.h
@@ -983,7 +983,8 @@ int qeth_do_send_packet_fast(struct qeth
 			     unsigned int hd_len);
 int qeth_do_send_packet(struct qeth_card *card, struct qeth_qdio_out_q *queue,
 			struct sk_buff *skb, struct qeth_hdr *hdr,
-			unsigned int hd_len, unsigned int offset, int elements);
+			unsigned int offset, unsigned int hd_len,
+			int elements_needed);
 int qeth_do_ioctl(struct net_device *dev, struct ifreq *rq, int cmd);
 int qeth_core_get_sset_count(struct net_device *, int);
 void qeth_core_get_ethtool_stats(struct net_device *,