From: Steve French <stfrench@microsoft.com>
Date: Wed, 15 Apr 2020 01:12:34 -0500
Subject: [PATCH] smb3: remove overly noisy debug line in signing errors
Git-commit: 9692ea9d3288a201df762868a52552b2e07e1c55
References: bsc#1144333
Patch-mainline: v5.7-rc2
A dump_stack call for signature related errors can be too noisy
and not of much value in debugging such problems.
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Shyam Prasad N <nspmangalore@gmail.com>
Acked-by: Paulo Alcantara <palcantara@suse.de>
---
fs/cifs/smb2transport.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- a/fs/cifs/smb2transport.c
+++ b/fs/cifs/smb2transport.c
@@ -573,9 +573,11 @@ smb2_verify_signature(struct smb_rqst *r
if (rc)
return rc;
- if (memcmp(server_response_sig, shdr->Signature, SMB2_SIGNATURE_SIZE))
+ if (memcmp(server_response_sig, shdr->Signature, SMB2_SIGNATURE_SIZE)) {
+ cifs_dbg(VFS, "sign fail cmd 0x%x message id 0x%llx\n",
+ shdr->Command, shdr->MessageId);
return -EACCES;
- else
+ } else
return 0;
}