From: Mario Limonciello <mario.limonciello@amd.com>
Date: Mon, 10 Apr 2023 00:23:41 +0530
Subject: [PATCH] platform/x86/amd: pmc: Don't try to read SMU version on
Picasso
References: bsc#1012628
Patch-mainline: 6.3.2
Git-commit: b845772677ea19b8e4c032bc07393ef32de4ee39
[ Upstream commit b845772677ea19b8e4c032bc07393ef32de4ee39 ]
Picasso doesn't support the command in the uPEP mailbox to try to
read the SMU version.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2449
Fixes: f6045de1f532 ("platform/x86: amd-pmc: Export Idlemask values based on the APU")
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230409185348.556161-2-Shyam-sundar.S-k@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
---
drivers/platform/x86/amd/pmc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/platform/x86/amd/pmc.c b/drivers/platform/x86/amd/pmc.c
index 2edaae04..4ffb08d2 100644
--- a/drivers/platform/x86/amd/pmc.c
+++ b/drivers/platform/x86/amd/pmc.c
@@ -403,6 +403,9 @@ static int amd_pmc_get_smu_version(struct amd_pmc_dev *dev)
int rc;
u32 val;
+ if (dev->cpu_id == AMD_CPU_ID_PCO)
+ return -ENODEV;
+
rc = amd_pmc_send_cmd(dev, 0, &val, SMU_MSG_GETSMUVERSION, 1);
if (rc)
return rc;
--
2.35.3