From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Date: Wed, 12 Jan 2022 19:27:22 +0100
Subject: ACPI: CPPC: Drop redundant local variable from cpc_read()
Patch-mainline: v5.17-rc1
Git-commit: f684b10751287e8b7e15e8f10ae40bdd74149bba
References: jsc#PED-1408
The ret_val local variable in cpc_read() is not necessary, so
eliminate it.
No functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Huang Rui <ray.huang@amd.com>
Acked-by: Lee, Chun-Yi <jlee@suse.com>
---
drivers/acpi/cppc_acpi.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/acpi/cppc_acpi.c
+++ b/drivers/acpi/cppc_acpi.c
@@ -928,14 +928,13 @@ int __weak cpc_write_ffh(int cpunum, str
static int cpc_read(int cpu, struct cpc_register_resource *reg_res, u64 *val)
{
- int ret_val = 0;
void __iomem *vaddr = NULL;
int pcc_ss_id = per_cpu(cpu_pcc_subspace_idx, cpu);
struct cpc_reg *reg = ®_res->cpc_entry.reg;
if (reg_res->type == ACPI_TYPE_INTEGER) {
*val = reg_res->cpc_entry.int_value;
- return ret_val;
+ return 0;
}
*val = 0;
@@ -981,10 +980,10 @@ static int cpc_read(int cpu, struct cpc_
default:
pr_debug("Error: Cannot read %u bit width from PCC for ss: %d\n",
reg->bit_width, pcc_ss_id);
- ret_val = -EFAULT;
+ return -EFAULT;
}
- return ret_val;
+ return 0;
}
static int cpc_write(int cpu, struct cpc_register_resource *reg_res, u64 val)