From: Quinn Tran <quinn.tran@cavium.com>
Date: Tue, 7 Aug 2018 20:39:52 -0700
Subject: [PATCH] scsi: qla2xxx: Fix issue reported by static checker for
qla2x00_els_dcmd2_sp_done()
References: bsc#1086327,FATE#324903
Git-commit: e9f7be0c4316a0ea1c47b1e800baa58fb937096c
Patch-mainline: v4.19-rc1
This patch fixes following Smatch complaint:
drivers/scsi/qla2xxx/qla_iocb.c:2647 qla2x00_els_dcmd2_sp_done()
error: we previously assumed 'e' could be null (see line 2631)
Fixes: 8777e4314d39 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Quinn Tran <quinn.tran@cavium.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/qla2xxx/qla_iocb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c
index f3115cbe067d..d18028be6ae9 100644
--- a/drivers/scsi/qla2xxx/qla_iocb.c
+++ b/drivers/scsi/qla2xxx/qla_iocb.c
@@ -2640,6 +2640,7 @@ qla2x00_els_dcmd2_sp_done(void *ptr, int res)
elsio->u.els_plogi.els_resp_pyld,
elsio->u.els_plogi.els_resp_pyld_dma);
sp->free(sp);
+ return;
}
e->u.iosb.sp = sp;
qla2x00_post_work(vha, e);
--
2.12.3