From 1d02c17d6ecc0eb1a917b77b72bac834952a86de Mon Sep 17 00:00:00 2001
From: Julia Lawall <julia.lawall@inria.fr>
Date: Sun, 12 Jun 2022 13:02:31 +0200
Subject: drm: fix device_node_continue.cocci warnings
Git-commit: d3a453416270f5c7f1bf409597d702a2230e5a6c
Patch-mainline: v6.0-rc1
References: jsc#PED-1166 jsc#PED-1168 jsc#PED-1170 jsc#PED-1218 jsc#PED-1220 jsc#PED-1222 jsc#PED-1223 jsc#PED-1225 jsc#PED-2849
drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put.
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.
Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/alpine.DEB.2.22.394.2206121300120.3447@hadrien
Acked-by: Patrik Jakobsson <pjakobsson@suse.de>
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
index 463653b2c109..31c5c42f0ac6 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -615,8 +615,6 @@ int logicvc_layers_init(struct logicvc_drm *logicvc)
ret = logicvc_layer_init(logicvc, layer_node, index);
if (ret)
goto error;
-
- of_node_put(layer_node);
}
of_node_put(layers_node);
--
2.38.1